On Mon, 12 Oct 2020 at 14:20, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > Note from Peter Maydell: > > The versatile/realview PCI controller has: > * three PCI BARs which represent memory windows on the > PCI bus which bus-master PCI devices can use to > write back into the system address space > - the device SMAPn registers allow the guest to configure > the mapping from "a bus-master access to an address > on the PCI bus wherever the guest mapped BAR n" > to "a system address", and the smap[] array holds > those register values > > Use self-explicit PCI_BAR_COUNT definition instead of a magic > value, and rename some misnamed variables indexing the smap[] > array from 'win' to 'bar'. > > Reported-by: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM