Hey John, Sorry for the late reply! I was in the midst of a job change and couldn't get time to get to this.
The work sounds interesting! I have a couple of questions regarding this: 1. How do I actually build this part? I am familiar with building and using QEMU. Does the qapi parser get built along with the main code? 2. If not, how do I start using this part and contributing to it? Thanks, Rohit. On Tue, Sep 29, 2020 at 9:38 PM John Snow <js...@redhat.com> wrote: > On 9/2/20 12:38 PM, Rohit Shinde wrote: > > Hey John, > > > > I wanted to follow up on this, in case you missed my previous email :) > > > > Thanks, > > Rohit. > > > > Sorry Rohit, very buried in my work and haven't been doing a good job > with my inbox. > > Right now, I am working on converting the QAPI parser module to the > strictly typed mypy subset: > > https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg09136.html > > There are six parts in all, that is part one. I am posting a v4 right > now as I write this. > > > Work that remains to be done after these six parts: > > - Get ./python/qemu passing under mypy/pylint/flake8 again. I have old > patches for this that were on-list prior to the 5.1 release. > > - Move ./scripts/qapi to ./python/qemu/qapi/ > > - Move ./python/qemu to ./python/qemu/core/ > > - Create a "make check" style script that will run > mypy/pylint/flake8/isort on all the code in ./python. (I have patches > for this, too.) > > - Start investigating python scripts in ./scripts and consider moving > them to ./python/qemu/tools, fixing them up to pass > mypy/flake8/pylint/isort (etc) as I go. There are no existing patches to > do this yet. > > > Other work I am doing: > > - Investigating the use of Pydantic to replace ./scripts/qapi/expr.py > - Investigating a YAML format for the QAPI parser > - Building a JSON-SCHEMA output format for the QAPI generator > > > > On Sat, Aug 29, 2020 at 1:14 AM Rohit Shinde > > <rohit.shinde12...@gmail.com <mailto:rohit.shinde12...@gmail.com>> > wrote: > > > > Hey John, > > > > Sorry to bother you! I just wanted to know if you had any thoughts > > on the mail I sent. > > > > Is there anything I can pick up right now with regards to the Python > > package? You mentioned that linting is something that needs to be > > completed before we go ahead, so maybe I can start with that? > > > > Thanks, > > Rohit. > > > >
