>> Hi Claudio, >> >> is there a reason why you removed current_cpu = cpu; from >> hax_cpu_thread_fn() when you moved that function to target/i386/hax-cpus.c? >> This change broke HAX on Windows. Adding back that line makes it work again. > > Hello Volker, I see the change in the history and it was clearly an ugly > mistake on my part. > There was no reason or intention to remove the current_cpu = cpu assignment > > The fix seems indeed to just + current_cpu = cpu; > and I will send a patch momentarily that does just that, > > but I don't know of any CI coverage for Windows + hax currently, > so it would be good if you could spin the change to verify that it fixes the > problem. >
That was very quick. Only 5 hours from bug report to pull request. I've tested current master together with the patch from Paolo's PR. HAX on Windows works. With best regards, Volker
