On 11/18/20 12:29 AM, frank.ch...@sifive.com wrote:
> +static bool trans_rori(DisasContext *ctx, arg_rori *a)
> +{
> + REQUIRE_EXT(ctx, RVB);
> +
> + if (a->shamt >= TARGET_LONG_BITS) {
> + return false;
> + }
> +
> + return gen_arith_shamt_tl(ctx, a, &tcg_gen_rotr_tl);
> +}
We most definitely want to use tcg_gen_rotri_tl here, as we have special
expansions of constant shifts for hosts without rotate (e.g. riscv64g ;-).
Otherwise, this patch should be included in the shift cleanup discussed
upthread.
r~
