On Wed, Dec 9, 2020 at 7:57 AM Richard Henderson <richard.hender...@linaro.org> wrote: > > On 12/8/20 4:56 PM, Alistair Francis wrote: > > The helper functions defined in helper.h specify that the argument is of > > type target_long. Let's change the implementation to match the header > > definition. > > Given that these are riscv64 specific, you could alternately change the header > definition. Dunno if that's clearer or not, considering an implementation > like > float32_to_int64 -- is it immediately obvious whether or not we are truncating > the result?
I suspect the headers are going to have to be changed before we have full dynamic xlen support. This series is already pretty large so here I just wanted to get it to compile without warnings. I think the FPU will take more work so I'm just going to put header changes off until then. Alistair > > > r~