Patchew URL: https://patchew.org/QEMU/20201211151300.85322-1-ag...@csgraf.de/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201211151300.85322-1-ag...@csgraf.de Subject: [PATCH v5 00/11] hvf: Implement Apple Silicon Support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20201210203549.379-1-peter.mayd...@linaro.org -> patchew/20201210203549.379-1-peter.mayd...@linaro.org * [new tag] patchew/20201211151300.85322-1-ag...@csgraf.de -> patchew/20201211151300.85322-1-ag...@csgraf.de - [tag update] patchew/20201211152426.350966-1-th...@redhat.com -> patchew/20201211152426.350966-1-th...@redhat.com Switched to a new branch 'test' 56f4c6b hvf: arm: Implement -cpu host b5c4db1 hvf: arm: Add support for GICv3 6c0280c arm/hvf: Add a WFI handler 26b170e arm: Add Hypervisor.framework build target a8820bd hvf: Add Apple Silicon support d0b5c38 hvf: Simplify post reset/init/loadvm hooks d3c68ab arm: Set PSCI to 0.2 for HVF 360f48e hvf: Introduce hvf vcpu struct 87a09e8 hvf: Move common code out ac925f0 hvf: x86: Remove unused definitions c77ce16 hvf: Add hypervisor entitlement to output binaries === OUTPUT BEGIN === 1/11 Checking commit c77ce16832fb (hvf: Add hypervisor entitlement to output binaries) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 62 lines checked Patch 1/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/11 Checking commit ac925f0aaf18 (hvf: x86: Remove unused definitions) 3/11 Checking commit 87a09e81f925 (hvf: Move common code out) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 1054 lines checked Patch 3/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/11 Checking commit 360f48eb839f (hvf: Introduce hvf vcpu struct) WARNING: line over 80 characters #142: FILE: target/i386/hvf/hvf.c:213: + wvmcs(cpu->hvf->fd, VMCS_ENTRY_CTLS, cap2ctrl(hvf_state->hvf_caps->vmx_cap_entry, ERROR: "(foo*)" should be "(foo *)" #750: FILE: target/i386/hvf/x86hvf.c:85: + if (hv_vcpu_write_fpstate(cpu_state->hvf->fd, (void*)xsave, 4096)) { ERROR: "(foo*)" should be "(foo *)" #831: FILE: target/i386/hvf/x86hvf.c:167: + if (hv_vcpu_read_fpstate(cpu_state->hvf->fd, (void*)xsave, 4096)) { total: 2 errors, 1 warnings, 996 lines checked Patch 4/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/11 Checking commit d3c68ab7fa96 (arm: Set PSCI to 0.2 for HVF) 6/11 Checking commit d0b5c38651d5 (hvf: Simplify post reset/init/loadvm hooks) 7/11 Checking commit a8820bd60f6a (hvf: Add Apple Silicon support) WARNING: architecture specific defines should be avoided #48: FILE: accel/hvf/hvf-cpus.c:61: +#ifdef __aarch64__ WARNING: architecture specific defines should be avoided #59: FILE: accel/hvf/hvf-cpus.c:335: +#ifdef __aarch64__ WARNING: architecture specific defines should be avoided #91: FILE: include/sysemu/hvf_int.h:15: +#ifdef __aarch64__ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #117: new file mode 100644 WARNING: line over 80 characters #579: FILE: target/arm/hvf/hvf.c:458: + hv_vcpu_set_pending_interrupt(cpu->hvf->fd, HV_INTERRUPT_TYPE_FIQ, true); WARNING: line over 80 characters #584: FILE: target/arm/hvf/hvf.c:463: + hv_vcpu_set_pending_interrupt(cpu->hvf->fd, HV_INTERRUPT_TYPE_IRQ, true); total: 0 errors, 6 warnings, 691 lines checked Patch 7/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/11 Checking commit 26b170ee618a (arm: Add Hypervisor.framework build target) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 total: 0 errors, 1 warnings, 36 lines checked Patch 8/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/11 Checking commit 6c0280c8b649 (arm/hvf: Add a WFI handler) 10/11 Checking commit b5c4db10905e (hvf: arm: Add support for GICv3) 11/11 Checking commit 56f4c6b7ff84 (hvf: arm: Implement -cpu host) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201211151300.85322-1-ag...@csgraf.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com