* Markus Armbruster (arm...@redhat.com) wrote:
> Commit 48c043d0d1 "hmp: human-monitor-command: stop using the Memory
> chardev driver" left us "if string is non-empty, duplicate it, else
> duplicate the empty string". Meh. Duplicate it unconditionally.
>
> Cc: Dr. David Alan Gilbert <dgilb...@redhat.com>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> ---
> monitor/misc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/monitor/misc.c b/monitor/misc.c
> index 398211a034..6c3e8506a9 100644
> --- a/monitor/misc.c
> +++ b/monitor/misc.c
> @@ -136,11 +136,7 @@ char *qmp_human_monitor_command(const char
> *command_line, bool has_cpu_index,
> handle_hmp_command(&hmp, command_line);
>
> WITH_QEMU_LOCK_GUARD(&hmp.common.mon_lock) {
> - if (qstring_get_length(hmp.common.outbuf) > 0) {
> - output = g_strdup(qstring_get_str(hmp.common.outbuf));
> - } else {
> - output = g_strdup("");
> - }
> + output = g_strdup(qstring_get_str(hmp.common.outbuf));
> }
>
> out:
> --
> 2.26.2
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
