Alex Bennée <alex.ben...@linaro.org> writes: > Peter Maydell <peter.mayd...@linaro.org> writes: > >> On Wed, 13 Jan 2021 at 09:31, Markus Armbruster <arm...@redhat.com> wrote: >>> >>> This pull request is on behalf of Lukas. Hope that's okay. >>> >>> The following changes since commit f8e1d8852e393b3fd524fb005e38590063d99bc0: >>> >>> Merge remote-tracking branch >>> 'remotes/pmaydell/tags/pull-target-arm-20210112-1' into staging (2021-01-12 >>> 21:23:25 +0000) >>> >>> are available in the Git repository at: >>> >>> git://repo.or.cz/qemu/armbru.git tags/pull-yank-2021-01-13 >>> >>> for you to fetch changes up to 91d48e520a4a4f72e97aeb333029694f5d57cc93: >>> >>> tests/test-char.c: Wait for the chardev to connect in >>> char_socket_client_dupid_test (2021-01-13 10:21:17 +0100) >>> >>> ---------------------------------------------------------------- >>> Yank patches patches for 2021-01-13 >>> >>> ---------------------------------------------------------------- >>> Lukas Straub (7): >>> Introduce yank feature >>> block/nbd.c: Add yank feature >>> chardev/char-socket.c: Add yank feature >>> migration: Add yank feature >>> io/channel-tls.c: make qio_channel_tls_shutdown thread-safe >>> io: Document qmp oob suitability of qio_channel_shutdown and >>> io_shutdown >>> tests/test-char.c: Wait for the chardev to connect in >>> char_socket_client_dupid_test >> >> >> Applied, thanks. > > This broke the check-unit and check-softfloat build task in Travis > > https://travis-ci.org/github/qemu/qemu/jobs/754436018 > > Likely because of missing stubs for the yank commands: > > FAILED: qemu-io > > gcc -o qemu-io qemu-io.p/qemu-io.c.o -Wl,--as-needed -Wl,--no-undefined > -pie -Wl,--whole-archive libblock.fa libcrypto.fa libauthz.fa libqom.fa > libio.fa -Wl,--no-whole-archive -Wl,--warn-common -Wl,-z,relro -Wl,-z,now > -m64 -fstack-protector-strong -Wl,--start-group libqemuutil.a > subprojects/libvhost-user/libvhost-user-glib.a > subprojects/libvhost-user/libvhost-user.a libblock.fa libcrypto.fa > libauthz.fa libqom.fa libio.fa @block.syms -lgnutls -pthread -lutil -lm > -lgthread-2.0 -lglib-2.0 -lgthread-2.0 -lglib-2.0 -lxml2 > /usr/lib/x86_64-linux-gnu/libiscsi.so -laio -lgthread-2.0 -lglib-2.0 > /usr/lib/x86_64-linux-gnu/libz.so /usr/lib/x86_64-linux-gnu/libnfs.so > /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libzstd.so -lssh > /usr/lib/x86_64-linux-gnu/libcurl.so > /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libbz2.so -lgnutls > -lnettle -lgnutls -lpam -lgnutls -Wl,--end-group > > /usr/bin/ld: libblock.fa(block_nbd.c.o): in function `nbd_close': > > /home/travis/build/qemu/qemu/build/../block/nbd.c:2358: undefined reference > to `yank_unregister_instance' [...] > collect2: error: ld returned 1 exit status
Reproduced locally: $ ../configure --disable-system --disable-user --enable-tools $ make Lukas, can you take care of this?