On Fri, Sep 02, 2011 at 02:38:25PM +1000, David Gibson wrote: > > I'd prefer the stubs to be inline. Not just as an optimization: > > it also makes it easier to grok what goes on in the common > > no-iommu case. > > To elaborate on my earlier mail. The problem with making them inlines > is that the cpu_physical_*() functions then appear in pci.h, which is > used in pci.c amongst other places that are included in > libhw32/libhw64, where those functions are poisoned.
Hmm, how are they poisoned? I thought almost all devices currently use cpu_physical_*()? For example, e1000 uses cpu_physical_memory_write and it seems to get included in libhw32/libhw64 without issues. > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ > _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson
