On 1/24/21 10:41 PM, Richard Henderson wrote: > On 1/24/21 10:24 AM, Philippe Mathieu-Daudé wrote: >> On 1/24/21 9:07 PM, Richard Henderson wrote: >>> Doesn't this get put in libutil, where it is only pulled from the archive >>> when >>> needed? Also, libutil is built once, not per-target. >> >> Hmm I just sent a pull request with this change squashed in. >> Should I cancel it? > > I guess not. > >> My view is we don't install libqemuutil.a anywhere, so why overload >> building unused objects when some configuration don't need it? > > My view is that util/meson.build should not be overly complicated with > conditionals.
Well I do see an impact when building on slow hosts. > If we were building objects per-target, that would be one thing. If we were > doing --whole-archive, and including unused code in the executables, that > would > be another thing. But otherwise... I understand your position :) Thanks, Phil.
