On Thu, Jan 28, 2021 at 04:00:20PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Jan 28, 2021 at 3:57 PM Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: > > > Hi > > > > On Thu, Jan 28, 2021 at 3:44 PM Gerd Hoffmann <kra...@redhat.com> wrote: > > > >> Hi, > >> > >> > diff --git a/ui/spice-display.c b/ui/spice-display.c > >> > index 0178d5766d..3d3e3bcb22 100644 > >> > --- a/ui/spice-display.c > >> > +++ b/ui/spice-display.c > >> > @@ -1188,4 +1188,6 @@ void qemu_spice_display_init(void) > >> > } > >> > qemu_spice_display_init_one(con); > >> > } > >> > >> if (runstate_is_running()) { > >> qemu_spice_display_start(); > >> } > >> > >> Isn't that enough? > >> > > > > That should be fine too, I'll update the patch. thanks > > > > Actually no, we still need to prevent the initial > qemu_spice_display_start(), and do a single call when everything is ready > (since spice server doesn't handle adding interfaces dynamically when > running).
I still think that moving these three lines to the correct place is enough. Maybe even just qemu_spice_display_start() as it keeps track of the state and you can safely call this twice. take care, Gerd