> -----Original Message----- > From: Richard Henderson <richard.hender...@linaro.org> > Sent: Sunday, March 14, 2021 1:02 PM > To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain <bc...@quicinc.com> > Subject: Re: [PATCH v8 27/35] Hexagon (target/hexagon) TCG for instructions > with multiple definitions > > On 3/13/21 6:41 PM, Taylor Simpson wrote: > >>> +#define fGEN_TCG_L2_loadrub_pr(SHORTCODE) SHORTCODE > >>> +#define fGEN_TCG_L2_loadrub_pi(SHORTCODE) SHORTCODE > >>> +#define fGEN_TCG_L2_loadrb_pr(SHORTCODE) SHORTCODE > >>> +#define fGEN_TCG_L2_loadrb_pi(SHORTCODE) SHORTCODE; > >>> +#define fGEN_TCG_L2_loadruh_pr(SHORTCODE) SHORTCODE > >>> +#define fGEN_TCG_L2_loadruh_pi(SHORTCODE) SHORTCODE; > >> > >> Why have some of these ; but not all? > > > > The initial series only has overrides that are required for correct > > execution. > > This does not answer the question re the semicolon inconsistency.
Sorry, misunderstood the question. The semi's must've been needed at some point, but they're not needed now. I'll remove them. Taylor
