On 3/17/21 2:44 PM, Wainer dos Santos Moschetta wrote:> On 3/17/21 10:26 AM, Philippe Mathieu-Daudé wrote: >> On 3/17/21 2:08 PM, Wainer dos Santos Moschetta wrote:> On 3/15/21 8:08 >> PM, Philippe Mathieu-Daudé wrote: >>>> The Avocado Test::fetch_asset() is handy to download artifacts >>>> before running tests. The current class is named Test but only >>>> tests system emulation. As we want to test user emulation, >>>> refactor the common code as QemuBaseTest. >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >>>> --- >>>> tests/acceptance/avocado_qemu/__init__.py | 23 >>>> ++++++++++++++++++++--- >>>> 1 file changed, 20 insertions(+), 3 deletions(-)
>>>> +# a.k.a. QemuSystemTest for system emulation... >>> Above comment could become the class docstring. >> No, there should be no comment at all. We have to see if we are OK to >> rename or not. You suggested this change: >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg659843.html >> But the there was more discussion and we never agreed on anything. >> I don't want to restart doing this change if it is ignored again, >> as it was a waste of time. > > I stand my suggestion to rename the Test class. However, IMO this could > be done on a separate series later after we get this merged, so to avoid > more discussion. I can work on it myself. Sound as a good plan for you? Sure, certainly! Thanks.
