John Snow <js...@redhat.com> writes: > Hi, this series adds static type hints to the QAPI module. > This is part four, and focuses on error.py. > > Part 4: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt4 > CI: https://gitlab.com/jsnow/qemu/-/pipelines/290152364 > > Requirements: > - Python 3.6+ > - mypy >= 0.770 > - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+) > > Every commit should pass with: > - `isort -c qapi/` > - `flake8 qapi/` > - `pylint --rcfile=qapi/pylintrc qapi/` > - `mypy --config-file=qapi/mypy.ini qapi/`
I doubt PATCH 1 is worth the trouble without an actual concrete location-less error. However, arguing about it some more would also not worth the trouble, so: Reviewed-by: Markus Armbruster <arm...@redhat.com> and queued. Thanks!
