Philippe Mathieu-Daudé <[email protected]> writes:
> Alex, Richard, do you mind reviewing this one please? Isn't it already merged (with my r-b tag no less ;-) f77147cd4de8c726f89b2702f7a9d0c9711d8875 Author: Philippe Mathieu-Daudé <[email protected]> AuthorDate: Fri Jan 22 21:44:31 2021 +0100 Commit: Paolo Bonzini <[email protected]> CommitDate: Mon Feb 8 14:43:55 2021 +0100 > > On 4/15/21 6:33 PM, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daudé <[email protected]> >> >> The previous attempt (commit f77147cd4de) doesn't work as >> expected, as we still have CONFIG_TCG=1 when using: >> >> configure --disable-system --disable-user >> >> Now than we have removed the use of CONFIG_TCG from target-dependent >> files in tests/qtest/, we can remove the unconditional definition of >> CONFIG_TCG in config_host. >> >> This avoid to build a bunch of unrequired objects when building with >> --disable-tcg (in particular the softfloat tests): >> >> Before: >> >> $ make >> [1/812] Generating trace-qom.h with a custom command >> ... >> >> After: >> >> $ make >> [1/349] Generating trace-qom.h with a custom command >> ... >> >> A difference of 463 objects... >> >> Reported-by: Claudio Fontana <[email protected]> >> Suggested-by: Paolo Bonzini <[email protected]> >> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> >> --- >> v3: Include Paolo's feedback: >> https://www.mail-archive.com/[email protected]/msg793872.html >> therefore o not include Alex's R-b tag. >> >> Cc: Richard Henderson <[email protected]> >> Cc: Alex Bennée <[email protected]> >> Cc: Emilio G. Cota <[email protected]> >> --- >> meson.build | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/meson.build b/meson.build >> index c6f4b0cf5e8..623cbe50685 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -262,7 +262,6 @@ >> language: ['c', 'cpp', 'objc']) >> >> accelerators += 'CONFIG_TCG' >> - config_host += { 'CONFIG_TCG': 'y' } >> endif >> >> if 'CONFIG_KVM' not in accelerators and get_option('kvm').enabled() >> -- Alex Bennée
