On 4/28/21 9:12 PM, Philippe Mathieu-Daudé wrote: > On 4/28/21 9:04 PM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé <phi...@redhat.com> writes: >> >>> On 4/28/21 7:06 PM, Alex Bennée wrote: >>>> Philippe Mathieu-Daudé <phi...@redhat.com> writes: >>>> >>>>> Alex, Richard, do you mind reviewing this one please? >>>> >>>> Isn't it already merged (with my r-b tag no less ;-) >>>> >>>> f77147cd4de8c726f89b2702f7a9d0c9711d8875 >>> >>> See ... >>> >>>> Author: Philippe Mathieu-Daudé <phi...@redhat.com> >>>> AuthorDate: Fri Jan 22 21:44:31 2021 +0100 >>>> Commit: Paolo Bonzini <pbonz...@redhat.com> >>>> CommitDate: Mon Feb 8 14:43:55 2021 +0100 >>>> >>>>> >>>>> On 4/15/21 6:33 PM, Philippe Mathieu-Daudé wrote: >>>>>> From: Philippe Mathieu-Daudé <f4...@amsat.org> >>>>>> >>>>>> The previous attempt (commit f77147cd4de) doesn't work as >>> >>> ... ^ this comment :( >> >> Ahh - my tooling was confused having searched by the subject title ;-) > > Oh I see, I'll rename as: > "tests/meson: Only build softfloat objects if TCG is selected (again)".
BTW you indeed reviewed/tested v1 of this patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg793900.html but after addressing Paolo's comments I preferred to remove your tags.
