On Mon, 2021-04-19 at 17:59 -0400, Eduardo Habkost wrote: > On Mon, Apr 19, 2021 at 04:18:25PM -0400, Eduardo Habkost wrote: > > On Fri, Apr 16, 2021 at 10:08:24AM +0800, Robert Hoo wrote: > > > Since commit fa4518741e (target-i386: Rename struct XMMReg to > > > ZMMReg), > > > CPUX86State.xmm_regs[] has already been extended to 512bit to > > > support > > > AVX512. > > > Also, other qemu level supports for AVX512 registers are there > > > for > > > years. > > > But in x86_cpu_dump_state(), still only dump XMM registers no > > > matter > > > YMM/ZMM is enabled. > > > This patch is to complement this, let it dump XMM/YMM/ZMM > > > accordingly. > > > > > > Signed-off-by: Robert Hoo <robert...@linux.intel.com> > > > > Queued for 6.1, thanks! > > Dequeuing, as it causes build failures on multiple configs: > > https://gitlab.com/ehabkost/qemu/-/pipelines/288890306 > > Example: > > > ../target/i386/cpu-dump.c: In function 'x86_cpu_dump_state': > ../target/i386/cpu-dump.c:511:50: error: format '%lx' expects > argument of type 'long unsigned int', but argument 4 has type > 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=] > qemu_fprintf(f, "Opmask%02d=%016lx%s", i, env- > >opmask_regs[i], > ~~~~~^ ~~~~~~~~~~ > ~~~~~~~~~ > %016llx > ../target/i386/cpu-dump.c:517:47: error: format '%lx' expects > argument of type 'long unsigned int', but argument 4 has type > 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=] > qemu_fprintf(f, "ZMM%02d=%016lx %016lx %016lx %016lx > %016lx " > ~~~~~^ > %016llx > Hi Eduardo,
I've sent v6 https://patchwork.kernel.org/project/qemu-devel/patch/1618986232-73826-1-git-send-email-robert...@linux.intel.com/ , would you retest and queue it? Thanks. >