On 5/6/21 4:06 AM, Vladimir Sementsov-Ogievskiy wrote: > write-notifiers are used only for write-threshold. New code for such > purpose should create filters. > > Let's better special-case write-threshold and drop write notifiers at > all. (Actually, write-threshold is special-cased anyway, as the only > user of write-notifiers)
As write-threshold is already partially special-cased, let's finish that special-casing and drop write notifiers altogether. > > So, create a new direct interface for bdrv_co_write_req_prepare() and > drop all write-notifier related logic from write-threshold.c. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > Reviewed-by: Max Reitz <mre...@redhat.com> > --- > > +/* > + * bdrv_write_threshold_check_write > + * > + * Check whether the specified request exceeds the write threshold. > + * If it is, send corresponding event and disable write threshold checking. s/it is, send/so, send a/ Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
