On 19/05/2021 13.05, Philippe Mathieu-Daudé wrote:
On 5/19/21 10:23 AM, Thomas Huth wrote:
On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote:
isa_superio_realize() calls isa_fdc_init_drives(), which is defined
in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol.
If I get that right, not all superio chipsets provide a floppy drive
(there's this "k->floppy.is_enabled" check in there) ... but for boards
that don't need the FDC, this would currently require a stub for that
function
Good point. I'll try to get it right.
As discussed in v6, all superio chips currently have a way to use an FDC, so
this version of the patch is fine:
Reviewed-by: Thomas Huth <th...@redhat.com>
