On 18/05/2021 07:12, Richard Henderson wrote:
On 5/17/21 3:50 PM, matheus.fe...@eldorado.org.br wrote:
+    if(a->l && (ctx->insns_flags & PPC_64B)) {

Space after IF.
> If I look back to the 6xx manual, I see

   NOTE: If L = 1, the instruction form is invalid.

The fact that we're allowing L=1 for ppc32 is an existing bug, afaics. We should fix that.


r~

The previous commit on this line in translate.c says that "on most 32bit CPUs we should always treat the compare as 32bit compare, as the CPU will ignore the L bit", so maybe it was intentional. Should we change it anyway?

--
Matheus K. Ferst
Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/>
Analista de Software Júnior
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

Reply via email to