On Wed, May 26, 2021 at 02:24:51PM -0700, Richard Henderson wrote: > On 5/26/21 2:13 PM, Luis Fernando Fujita Pires wrote: > > From: Bruno Larsen (billionai) <bruno.lar...@eldorado.org.br> > > > Before this patch, when PPC_DUMP_CPU is set, oname is added to > > > opc_handler_t, but GEN_OPCODE* wouldn't set it unless DO_PPC_STATISTICS > > > was set as well. > > > > > > This patch changes it so those changes would happen when PPC_DUMP_CPU is > > > set, but not statistics, because the latter is being removed. > > > > > > Signed-off-by: Bruno Larsen (billionai) <bruno.lar...@eldorado.org.br> > > > --- > > > target/ppc/translate.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I suggest removing dump_ppc_insns() altogether and 'oname' along with it. > > > > Now that we're moving to decodetree, dump_ppc_insns() wouldn't show all the > > available opcodes anyway. And the only other locations where 'oname' is > > being used are when registering more than one handler for the same opcode > > by mistake, which won't happen anymore, as any new instructions should use > > decodetree. > > Agreed.
I'll wait for a follow up doing this then.
>
> r~
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
