On Wed, May 26, 2021 at 05:21:02PM -0300, Bruno Larsen (billionai) wrote: > Removed the commented out definition and all ifdefs relating to > PPC_DUMP_STATISTICS, as it's hardly ever used. > > Suggested-by: Richard Henderson <richard.hender...@linaro.org> > Signed-off-by: Bruno Larsen (billionai) > <bruno.lar...@eldorado.org.br>
Applied to ppc-for-6.1, thanks.
> ---
> target/ppc/translate.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index fc9fd790ca..0525e1939f 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -47,7 +47,6 @@
>
> /* Include definitions for instructions classes and implementations flags */
> /* #define PPC_DEBUG_DISAS */
> -/* #define DO_PPC_STATISTICS */
>
> #ifdef PPC_DEBUG_DISAS
> # define LOG_DISAS(...) qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__)
> @@ -217,12 +216,9 @@ struct opc_handler_t {
> uint64_t type2;
> /* handler */
> void (*handler)(DisasContext *ctx);
> -#if defined(DO_PPC_STATISTICS) || defined(PPC_DUMP_CPU)
> +#if defined(PPC_DUMP_CPU)
> const char *oname;
> #endif
> -#if defined(DO_PPC_STATISTICS)
> - uint64_t count;
> -#endif
> };
>
> /* SPR load/store helpers */
> @@ -8546,7 +8542,7 @@ static int register_direct_insn(opc_handler_t
> **ppc_opcodes,
> if (insert_in_table(ppc_opcodes, idx, handler) < 0) {
> printf("*** ERROR: opcode %02x already assigned in main "
> "opcode table\n", idx);
> -#if defined(DO_PPC_STATISTICS) || defined(PPC_DUMP_CPU)
> +#if defined(PPC_DUMP_CPU)
> printf(" Registered handler '%s' - new handler '%s'\n",
> ppc_opcodes[idx]->oname, handler->oname);
> #endif
> @@ -8570,7 +8566,7 @@ static int register_ind_in_table(opc_handler_t **table,
> if (!is_indirect_opcode(table[idx1])) {
> printf("*** ERROR: idx %02x already assigned to a direct "
> "opcode\n", idx1);
> -#if defined(DO_PPC_STATISTICS) || defined(PPC_DUMP_CPU)
> +#if defined(PPC_DUMP_CPU)
> printf(" Registered handler '%s' - new handler '%s'\n",
> ind_table(table[idx1])[idx2]->oname, handler->oname);
> #endif
> @@ -8581,7 +8577,7 @@ static int register_ind_in_table(opc_handler_t **table,
> insert_in_table(ind_table(table[idx1]), idx2, handler) < 0) {
> printf("*** ERROR: opcode %02x already assigned in "
> "opcode table %02x\n", idx2, idx1);
> -#if defined(DO_PPC_STATISTICS) || defined(PPC_DUMP_CPU)
> +#if defined(PPC_DUMP_CPU)
> printf(" Registered handler '%s' - new handler '%s'\n",
> ind_table(table[idx1])[idx2]->oname, handler->oname);
> #endif
> @@ -9036,10 +9032,6 @@ static void ppc_tr_translate_insn(DisasContextBase
> *dcbase, CPUState *cs)
> gen_invalid(ctx);
> }
>
> -#if defined(DO_PPC_STATISTICS)
> - handler->count++;
> -#endif
> -
> translator_loop_temp_check(&ctx->base);
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
