On 6/8/21 3:10 PM, Daniel P. Berrangé wrote: > On Tue, Jun 08, 2021 at 02:25:37PM -0500, Connor Kuehl wrote: >> It may not be appropriate for me to take over as a maintainer at this time, >> but I would consider myself familiar with AMD SEV and what this code is >> meant to be doing as part of a VMM for launching SEV-protected guests. >> >> To that end, I would be happy to volunteer as a reviewer for SEV-related >> changes so that I am CC'd on them and can help share the review burden with >> whoever does maintain this code. >> >> Signed-off-by: Connor Kuehl <cku...@redhat.com> >> --- >> Note: because there's no maintainer entry, when running >> ./scripts/get_maintainers.pl on target/i386/sev.c, my name and the qemu >> mailing list is the only thing that shows up... it doesn't even show >> previous committers (as it would before applying this patch). Which is >> probably not great considering I do not make pull requests to QEMU. >> >> Is the way forward to get someone to sign up as a maintainer before >> applying a patch like this? > > There's no requirement to have a maintainer before having a reviewer. > If any of the existing committers shown do send pull requests, it is > probably co-incidental since they're not listed as official maintainers, > and being listed as Reviewer doesn't commit you to doing pull requests. > > That said if you're the only nominated reviewer and actually do useful > reviews, you will probably quickly find yourself the defacto maintainer > in 12 months time and end up doing pull requests...
Right, I am just worried that if I am the only person that shows up in the get_maintainer.pl output, the submitter will have to know some other way who a relevant maintainer is that can take the patches otherwise they won't be CC'd. Or we'll have to hope a relevant maintainer sees them on the list. Or I'll have to chase down a maintainer myself assuming the reviews all check out. :-) Connor
