On Thu, Jun 10, 2021 at 08:32:05AM +0200, Gerd Hoffmann wrote: > On Wed, Jun 09, 2021 at 04:14:12PM +0100, Stefan Hajnoczi wrote: > > On Tue, Jun 01, 2021 at 03:24:01PM +0200, Gerd Hoffmann wrote: > > > First version that actually works. Only qxl covered for this RfC, > > > other modules will follow once the basics are hashed out. > > > > > > v4: > > > - rebase to latest master. > > > - fix systemtap tracing. > > > - also cover virtio-gpu modules. > > > - pick up some review tags. > > > - misc minor tweaks. > > > > > > v3: > > > - handle initialization of modular tracepoints. > > > > > > TODO: > > > Enabling modular tracepoints via -trace cmd line doesn't work yet. > > > Guess we need to store the list somewhere for later re-processing. > > > Error handling is tricky, specifically the "tracepoint doesn't exist" > > > error. Suggestions / ideas are welcome. > > > > Excellent! I think we discussed these TODOs in the past. Can we merge > > this series in close to its current form or does it degrade the tracing > > experience (e.g. does the -trace command-line no longer work for > > trace-events files that were split off into modules)? > > Main focus for v4 was to make stap work. > The cmd line issue is still there. > > Patches 1-5 can be cherry-picked without breaking something.
Thanks, I have applied Patches 1-5 to my tracing tree: https://gitlab.com/stefanha/qemu/-/tree/tracing Stefan
signature.asc
Description: PGP signature
