Markus Armbruster <arm...@redhat.com> writes: > marcandre.lur...@redhat.com writes: > >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> Instead of building prepocessor conditions from a list of string, use >> the result generated from QAPISchemaIfCond.cgen(). > > I understand why you're doing this, but only because I know where you're > headed. By itself, it is not an improvement: you move C generation out > of common.py into schema.py. You need to explain why that's useful. > >> >> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> >> --- >> scripts/qapi/common.py | 24 +++++++++++------------- >> scripts/qapi/gen.py | 4 ++-- >> scripts/qapi/introspect.py | 4 ++-- >> scripts/qapi/schema.py | 3 +++ >> scripts/qapi/types.py | 20 ++++++++++---------- >> scripts/qapi/visit.py | 12 ++++++------ >> 6 files changed, 34 insertions(+), 33 deletions(-) > > Missing: qapi-code-gen.txt section "Configuring the schema" has an > example, which needs to be updated.
Nope, that's in PATCH 1 already. > When the generated code changes, always check the examples, and always > consider describing the change in the commit message. Describing the change in the commit message is even more useful when the doc update isn't in the same patch. [...]
