Marc-André Lureau <marcandre.lur...@gmail.com> writes: > Hi > > On Mon, Jun 14, 2021 at 4:48 PM Markus Armbruster <arm...@redhat.com> wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau <marcandre.lur...@redhat.com> >> > >> > Instead of building prepocessor conditions from a list of string, use >> > the result generated from QAPISchemaIfCond.cgen(). >> >> I understand why you're doing this, but only because I know where you're >> headed. By itself, it is not an improvement: you move C generation out >> of common.py into schema.py. You need to explain why that's useful. >> >> > What about? > > In the following commits, QAPISchemaIfCond is going to hold an internal > tree structure. Moving cgen() there allows to abstract away the condition > representation.
Yes, that's better. [...]
