Hi,

One thing that could be improved after this patch is that the ledstate
is now present both in spice-input and hw/ps2.c, but I couldn't find
an easy way to get the ps2 ledstate from spice-input so I left things
this way for now.

Directly linking ps/2 and spice-input would be wrong anyway as there are other keyboards (usb) too ...

input.c could cache the ledstate and offer a kbd_get_ledstate function, so anyone interested in the state doesn't need to keep it itself. That is a pretty minor thing though IMHO.

cheers,
  Gerd


Reply via email to