Hi
On Tue, Oct 11, 2011 at 10:49 AM, Gerd Hoffmann <kra...@redhat.com> wrote:
>> +#else
>> +#warning "Spice playback volume unsupported"
>> +#endif
>
>> +#else
>> +#warning "Spice record volume unsupported"
>> +#endif
>
> One warning is enougth. But given that qemu builds with -Werror by default
> printing a warning just because of an older spice-server version is a bad
> idea IMHO.
There were 2 warnings, because the interfaces checked are different.
But since qemu build with -Werror, let's just remove them.
>> @@ -337,6 +379,7 @@ struct audio_driver spice_audio_driver = {
>> .max_voices_in = 1,
>> .voice_size_out = sizeof (SpiceVoiceOut),
>> .voice_size_in = sizeof (SpiceVoiceIn),
>> + .ctl_caps = VOICE_VOLUME_CAP
>
> This should be #ifdef'ed too I guess?
Agreed, to fallback on mixemu volume in that case.
--
Marc-André Lureau
