Hi Julia, On Thu, Jun 17, 2021 at 10:07 PM Julia Suvorova <jus...@redhat.com> wrote:
> The patch set consists of two parts: > patches 1-4: introduce new feature > 'acpi-pci-hotplug-with-bridge-support' on Q35 > patches 5-7: make the feature default along with changes in ACPI tables > > I have tested the patches and I noticed 2 issues: 1. The changes allow to hotplug a device into the pcie.0 bus (device_add e1000) - The device can be seen using `info qtree` but is not visible in guest. pcie.0 bus should not support hotplug at all. Before the series we get: Error: Bus 'pcie.0' does not support hotplugging 2. The devices hotplugged into a pcie-root-port are not allocated IO space: device_add e1000,id=e1,bus=rp1 In dmesg I see: [ 24.699178] pci 0000:01:00.0: BAR 1: no space for [io size 0x0040] [ 24.699753] pci 0000:01:00.0: BAR 1: failed to assign [io size 0x0040] And in lspci I see: I/O ports at <unassigned> [disabled] Before the series: I/O ports at 1000 [size=64] Could you please check? Thanks, Marcel