On 7/13/21 5:31 AM, Thomas Huth wrote: > Many features do not get properly disabled when the user runs the > configure script with --without-default-features. Let's fix that now. > > Thomas Huth (4): > configure: Fix --without-default-features propagation to meson > configure: Allow vnc to get disabled with --without-default-features > configure: Fix the default setting of the "xen" feature > configure: Let --without-default-features disable vhost-kernel and > vhost-vdpa >
Patches look fine and fix some issues but others persist (--disable-system isn't triggered). IMO this needs an audit, but more importantly 'configure' should be rearranged a bit to make this less likely to regress: * move all the --enable/--disable variable init into one section with nothing else mixed in * convert the values to all use $default_yes/no/auto/enabled/disabled/... variable syntax so visually it's consistent, and if a default is ever changed like $default_no -> $default_yes then we behave correctly (as opposed to 'no' -> 'yes'). Thanks, Cole
