On Tue, 20 Jul 2021 15:16:40 +0200 Igor Mammedov <imamm...@redhat.com> wrote:
> On Wed, 30 Jun 2021 15:07:17 -0400 > Eric DeVolder <eric.devol...@oracle.com> wrote: [...] > > +/* ACPI 4.0: 17.4.1 Serialization Action Table */ > > +void build_erst(GArray *table_data, BIOSLinker *linker, Object *erst_dev, > > + const char *oem_id, const char *oem_table_id) > > +{ > > + ERSTDeviceState *s = ACPIERST(erst_dev); > > globals are not welcomed in new code, > pass erst_dev as argument here (ex: find_vmgenid_dev) ignore this, I didn't notice that it's passed as argument.