On 7/20/21 2:53 PM, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer points to NULL for the second > call. > > pci_proxy_dev_realize() is wrong that way: it passes @errp to > qio_channel_new_fd() without checking for failure. If it runs into > another failure, it trips error_setv()'s assertion. > > Fix it to check for failure properly. > > Fixes: 9f8112073aad8e485ac012ee18809457ab7f23a6 > Cc: Elena Ufimtseva <elena.ufimts...@oracle.com> > Cc: Jagannathan Raman <jag.ra...@oracle.com> > Cc: John G Johnson <john.g.john...@oracle.com> > Cc: Stefan Hajnoczi <stefa...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/remote/proxy.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
