> On Jul 20, 2021, at 8:53 AM, Markus Armbruster <arm...@redhat.com> wrote: > > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer points to NULL for the second > call. > > pci_proxy_dev_realize() is wrong that way: it passes @errp to > qio_channel_new_fd() without checking for failure. If it runs into > another failure, it trips error_setv()'s assertion. > > Fix it to check for failure properly. > > Fixes: 9f8112073aad8e485ac012ee18809457ab7f23a6 > Cc: Elena Ufimtseva <elena.ufimts...@oracle.com> > Cc: Jagannathan Raman <jag.ra...@oracle.com> > Cc: John G Johnson <john.g.john...@oracle.com> > Cc: Stefan Hajnoczi <stefa...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/remote/proxy.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Acked-by: Jagannathan Raman <jag.ra...@oracle.com>
- Re: [PATCH 10/16] migration: Handle migra... Markus Armbruster
- Re: [PATCH 10/16] migration: Handle migration... Pankaj Gupta
- Re: [PATCH 10/16] migration: Handle migration... Dr. David Alan Gilbert
- [PATCH 07/16] vfio: Avoid error_propagate() after ... Markus Armbruster
- Re: [PATCH 07/16] vfio: Avoid error_propagate... Philippe Mathieu-Daudé
- Re: [PATCH 07/16] vfio: Avoid error_propagate... Kirti Wankhede
- Re: [PATCH 07/16] vfio: Avoid error_propagate... Paolo Bonzini
- Re: [PATCH 07/16] vfio: Avoid error_propa... Markus Armbruster
- [PATCH 04/16] multi-process: Fix pci_proxy_dev_rea... Markus Armbruster
- Re: [PATCH 04/16] multi-process: Fix pci_prox... Philippe Mathieu-Daudé
- Re: [PATCH 04/16] multi-process: Fix pci_prox... Jag Raman
- [PATCH 12/16] vhost: Clean up how VhostOpts method... Markus Armbruster
- Re: [PATCH 12/16] vhost: Clean up how VhostOp... Philippe Mathieu-Daudé
- Re: [PATCH 12/16] vhost: Clean up how Vho... Markus Armbruster
- Re: [PATCH 12/16] vhost: Clean up how VhostOp... Philippe Mathieu-Daudé
- [PATCH 11/16] microvm: Drop dead error handling in... Markus Armbruster
- Re: [PATCH 11/16] microvm: Drop dead error ha... Sergio Lopez
- Re: [PATCH 11/16] microvm: Drop dead error ha... Philippe Mathieu-Daudé
- Re: [PATCH 11/16] microvm: Drop dead error ha... Pankaj Gupta
- [PATCH 14/16] Remove superfluous ERRP_GUARD() Markus Armbruster
- Re: [PATCH 14/16] Remove superfluous ERRP_GUA... Philippe Mathieu-Daudé