Hi Peter, On 10:33 Thu 12 Aug , Peter Maydell wrote: > diff --git a/hw/core/clock.c b/hw/core/clock.c > index fc5a99683f8..c371b9e977a 100644 > --- a/hw/core/clock.c > +++ b/hw/core/clock.c
> @@ -133,10 +143,21 @@ char *clock_display_freq(Clock *clk) > return freq_to_str(clock_get_hz(clk)); > } > > +void clock_set_mul_div(Clock *clk, uint32_t multiplier, uint32_t divider) > +{ > + assert(divider != 0); > + Maybe add a trace here to ease debugging? > + clk->multiplier = multiplier; > + clk->divider = divider; > +} > + Otherwise: Reviewed-by: Luc Michel <l...@lmichel.fr>