Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

[Richard Henderson]

On 8/30/21 2:38 PM, Philippe Mathieu-Daudé wrote:
+#if defined(TARGET_RISCV128)
+        if (is_128bit(ctx)) {

Maybe this could allow the compiler eventually elide the
code and avoid superfluous #ifdef'ry:

            if (TARGET_LONG_BITS >= 128) {

TCG does not support TARGET_LONG_BITS != {32,64}.
This will not work.

But is_128bit() should be sufficient in each opcode, because that itself should evaluate 
to false if unsupported.


r~