On Tue, Oct 05, 2021 at 09:38:13PM +0200, Eric Auger wrote: > Hi Jean, > > On 10/1/21 7:33 PM, Jean-Philippe Brucker wrote: > > The VIOT blob contains the following: > > > > [000h 0000 4] Signature : "VIOT" [Virtual I/O > > Translation Table] > > [004h 0004 4] Table Length : 00000058 > > [008h 0008 1] Revision : 00 > > [009h 0009 1] Checksum : 66 > > [00Ah 0010 6] Oem ID : "BOCHS " > > [010h 0016 8] Oem Table ID : "BXPC " > > [018h 0024 4] Oem Revision : 00000001 > > [01Ch 0028 4] Asl Compiler ID : "BXPC" > > [020h 0032 4] Asl Compiler Revision : 00000001 > > > > [024h 0036 2] Node count : 0002 > > [026h 0038 2] Node offset : 0030 > > [028h 0040 8] Reserved : 0000000000000000 > > > > [030h 0048 1] Type : 03 [VirtIO-PCI IOMMU] > > [031h 0049 1] Reserved : 00 > > [032h 0050 2] Length : 0010 > > > > [034h 0052 2] PCI Segment : 0000 > > [036h 0054 2] PCI BDF number : 0008 > > [038h 0056 8] Reserved : 0000000000000000 > > > > [040h 0064 1] Type : 01 [PCI Range] > > [041h 0065 1] Reserved : 00 > > [042h 0066 2] Length : 0018 > > > > [044h 0068 4] Endpoint start : 00000000 > > [048h 0072 2] PCI Segment start : 0000 > > [04Ah 0074 2] PCI Segment end : 0000 > > [04Ch 0076 2] PCI BDF start : 0000 > > [04Eh 0078 2] PCI BDF end : 00FF > > [050h 0080 2] Output node : 0030 > > [052h 0082 6] Reserved : 000000000000 > I noticed the spec does not clearly say the virtio-iommu-pci BDF does > not need to be excluded from the PCI range. > Shouldn't it be clarified?
Possibly, but I didn't want to complicate things. As the spec doesn't specify any exception the driver should handle it > > Besides > Reviewed-by: Eric Auger <eric.au...@redhat.com> Thanks! Jean
