On 10/28/21 17:54, Daniel P. Berrangé wrote: > This is a counterpart to the HMP "info cmma" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long term guaranteed stability. > The existing HMP command is rewritten to call the QMP command. > > This command is unable to use the pre-existing HumanReadableText, > because if 'common.json' is included into 'machine-target.json' > the static marshalling method for HumanReadableText will be reported > as unused by the compiler on all architectures except s390x. > > Possible options were > > 1 Support 'if' conditionals on 'include' statements in QAPI > 2 Add further commands to 'machine-target.json' that use > HumanReadableText, such that it has at least one usage > on all architecture targets. > 3 Duplicate HumanReadableText as TargetHumanReadableText > adding conditions > > This patch takes option (3) in the belief that we will eventually > get to a point where option (2) happens, and TargetHumanReadableText > can be removed again. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > hw/s390x/s390-stattrib.c | 56 +++++++++++++++++++++++++++------------- > qapi/machine-target.json | 14 ++++++++++ > 2 files changed, 52 insertions(+), 18 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
