Jonathan Cameron <jonathan.came...@huawei.com> writes:
> On Tue, 30 Nov 2021 09:21:58 -0800 > Ben Widawsky <ben.widaw...@intel.com> wrote: > >> On 21-11-30 13:09:56, Jonathan Cameron wrote: >> > On Mon, 29 Nov 2021 18:28:43 +0000 >> > Alex Bennée <alex.ben...@linaro.org> wrote: >> > >> > > Ben Widawsky <ben.widaw...@intel.com> writes: >> > > >> > > > On 21-11-26 12:08:08, Alex Bennée wrote: >> > > >> >> > > >> Ben Widawsky <ben.widaw...@intel.com> writes: >> > > >> <snip> >> > > >> > > >> * Some means at least ensuring qtest can instantiate the device and >> > > >> not >> > > >> fall over. Obviously more testing is better but it can always be >> > > >> expanded on in later series. >> > > > >> > > > This was in the patch series. It could use more testing for sure, but >> > > > I had >> > > > basic functional testing in place via qtest. >> > > >> > > More is always better but the basic qtest does ensure a device doesn't >> > > segfault if it's instantiated. >> > >> > I'll confess this is a bit I haven't looked at yet. Will get Shameer to >> > give >> > me a hand. >> > >> > Thanks >> >> I'd certainly feel better if we had more tests. I also suspect the qtest I >> wrote >> originally no longer works. The biggest challenge I had was getting gitlab CI >> working for me. > > Looks like it'll be tests that slow things down. *sigh*. Hopefully the GitLab stuff has stabilised over the last year as we've aggressively pushed out stuff that times out and also limited some test to only run on upstream staging branches. The biggest hole is properly exercising KVM stuff (due to the limitations of GitLab runners). As a result you fall back to TCG which can get slow if your booting full distros with it. > Why are there not enough days in the week? "oh it's softfreeze already?" - a regular occurrence for me ;-) > > Jonathan -- Alex Bennée
