On 11/09/2011 01:44 PM, Aneesh Kumar K.V wrote: > On Wed, 9 Nov 2011 12:33:58 +0200, Avi Kivity <a...@redhat.com> wrote: > > Modern distributions place xattr.h in /usr/include/sys, and fold > > libattr.so into libc. They also don't have an ENOATTR. > > > > Make configure detect this, and add a qemu-xattr.h file that > > directs the #include to the right place. > > > > @@ -3032,6 +3037,9 @@ fi > > if test "$attr" = "yes" ; then > > echo "CONFIG_ATTR=y" >> $config_host_mak > > fi > > +if test "$libattr" = "yes" ; then > > + echo "CONFIG_LIBATTR=y" >> $config_host_mak > > +fi > > Is this needed ? We are adding -lattr to LIBS if needed. What will > CONFIG_LIBATTR helps us to achieve ?
It's needed to select <sys/xattr.h> vs <attr/xattr.h>. > > #include <sys/socket.h> > > #include <sys/un.h> > > -#include <attr/xattr.h> > > +#include <qemu-xattr.h> > > Should this be > > #include "qemu-xattr.h" Ugh, yes. Will fix. -- error compiling committee.c: too many arguments to function
