On Thu, Dec 23, 2021 at 12:07:53PM +0100, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/block/trace-events b/block/trace-events > index 549090d453..5be3e3913b 100644 > --- a/block/trace-events > +++ b/block/trace-events > @@ -49,15 +49,6 @@ block_copy_read_fail(void *bcs, int64_t start, int ret) > "bcs %p start %"PRId64" > block_copy_write_fail(void *bcs, int64_t start, int ret) "bcs %p start > %"PRId64" ret %d" > block_copy_write_zeroes_fail(void *bcs, int64_t start, int ret) "bcs %p > start %"PRId64" ret %d" > > -# ../blockdev.c > -qmp_block_job_cancel(void *job) "job %p" > -qmp_block_job_pause(void *job) "job %p" > -qmp_block_job_resume(void *job) "job %p" > -qmp_block_job_complete(void *job) "job %p" > -qmp_block_job_finalize(void *job) "job %p" > -qmp_block_job_dismiss(void *job) "job %p" > -qmp_block_stream(void *bs) "bs %p" > - > # file-win32.c > file_paio_submit(void *acb, void *opaque, int64_t offset, int count, int > type) "acb %p opaque %p offset %"PRId64" count %d type %d" > > diff --git a/trace-events b/trace-events > index a637a61eba..1265f1e0cc 100644 > --- a/trace-events > +++ b/trace-events > @@ -79,14 +79,6 @@ job_state_transition(void *job, int ret, const char > *legal, const char *s0, con > job_apply_verb(void *job, const char *state, const char *verb, const char > *legal) "job %p in state %s; applying verb %s (%s)" > job_completed(void *job, int ret) "job %p ret %d" > > -# job-qmp.c > -qmp_job_cancel(void *job) "job %p" > -qmp_job_pause(void *job) "job %p" > -qmp_job_resume(void *job) "job %p" > -qmp_job_complete(void *job) "job %p" > -qmp_job_finalize(void *job) "job %p" > -qmp_job_dismiss(void *job) "job %p"
The job pointer argument will be lost. That's not ideal but probably worth getting trace events for all QMP commands. Stefan
signature.asc
Description: PGP signature