On Wed, 9 Feb 2022 at 13:23, Alex Bennée <alex.ben...@linaro.org> wrote: > > > Peter Maydell <peter.mayd...@linaro.org> writes: > > > On Wed, 9 Feb 2022 at 11:35, Alex Bennée <alex.ben...@linaro.org> wrote: > >> linux-user wants to trap all signals in case they are related to the > >> guest. This however results in less than helpful core dumps when the > >> error is internal to QEMU. We can detect when an assert failure is in > >> progress by examining __glib_assert_msg and fall through to > >> cpu_abort() which will pretty print something before restoring the > >> default SIGABRT behaviour and dumping core. > > > > There is definitely a problem here that it would be nice to > > fix, but __glib_assert_msg is as far as I can tell not a > > documented public-facing glib API, > > Yeah it's in an odd position - it is explicitly exported but not > documented as an API but for use by crash tools: > > https://gitlab.gnome.org/GNOME/glib/-/issues/712
Mmm. I think if glib specifically mark it as "not part of our API" then we should not be touching it. -- PMM
