On Tue, Jan 18, 2022 at 05:09:09PM +0100, Vladimir Sementsov-Ogievskiy wrote:
> Add simple test-case for new addresses argument of display-reload qmp
> command.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
> ---
> tests/avocado/vnc.py | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tests/avocado/vnc.py b/tests/avocado/vnc.py
> index 096432988f..936285a50b 100644
> --- a/tests/avocado/vnc.py
> +++ b/tests/avocado/vnc.py
> @@ -51,3 +51,13 @@ def test_change_password(self):
> set_password_response = self.vm.qmp('change-vnc-password',
> password='new_password')
> self.assertEqual(set_password_response['return'], {})
> +
> + def test_change_listen(self):
> + self.vm.add_args('-nodefaults', '-S', '-vnc', ':0')
> + self.vm.launch()
> + self.assertEqual(self.vm.qmp('query-vnc')['return']['service'],
> '5900')
Add a check that socket connect(5900) works here and connect(5901)
and connect(5902) fails...
> + res = self.vm.qmp('display-reload', type='vnc',
> + addresses=[{'type': 'inet', 'host': '0.0.0.0',
> + 'port': '5901'}])
I'd suggest we provide multiple addresses to test multi address
changes on distinct IPs too
addresses=[{'type': 'inet', 'host': '0.0.0.0',
'port': '5901'},
{'type': 'inet', 'host': '127.0.0.1',
'port': '5902'}]
> + self.assertEqual(res['return'], {})
> + self.assertEqual(self.vm.qmp('query-vnc')['return']['service'],
> '5901')
and connect(5900) fails here, and connect(5901) + connet(5902) works .
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
