On Fri, Mar 18, 2022 at 9:36 AM Hanna Reitz <hre...@redhat.com> wrote: > > On 18.03.22 00:49, John Snow wrote: > > Hiya! > > > > This series effectively replaces qemu_img_pipe_and_status() with a > > rewritten function named qemu_img() that raises an exception on non-zero > > return code by default. By the end of the series, every last invocation > > of the qemu-img binary ultimately goes through qemu_img(). > > > > The exception that this function raises includes stdout/stderr output > > when the traceback is printed in a a little decorated text box so that > > it stands out from the jargony Python traceback readout. > > > > (You can test what this looks like for yourself, or at least you could, > > by disabling ztsd support and then running qcow2 iotest 065.) > > > > Negative tests are still possible in two ways: > > > > - Passing check=False to qemu_img, qemu_img_log, or img_info_log > > - Catching and handling the CalledProcessError exception at the callsite. > > Thanks! Applied to my block branch: > > https://gitlab.com/hreitz/qemu/-/commits/block > > Hanna >
Actually, hold it -- this looks like it is causing problems with the Gitlab CI. I need to investigate these. https://gitlab.com/jsnow/qemu/-/pipelines/495155073/failures ... and, ugh, naturally the nice error diagnostics are suppressed here so I can't see them. Well, there's one more thing to try and fix somehow. --js
