On 23.03.22 09:39, Thomas Huth wrote:
On 22/03/2022 18.42, John Snow wrote:
Quite a few of these tests have stale contact information. This patch
updates the stale ones that I happen to be aware of at the moment.

Signed-off-by: John Snow <js...@redhat.com>
---
  tests/qemu-iotests/025 | 2 +-
  tests/qemu-iotests/027 | 2 +-
  tests/qemu-iotests/028 | 2 +-
  tests/qemu-iotests/036 | 2 +-
  tests/qemu-iotests/039 | 2 +-
  tests/qemu-iotests/059 | 2 +-
  tests/qemu-iotests/060 | 2 +-
  tests/qemu-iotests/061 | 2 +-
  tests/qemu-iotests/062 | 2 +-
  tests/qemu-iotests/064 | 2 +-
  tests/qemu-iotests/066 | 2 +-
  tests/qemu-iotests/068 | 2 +-
  tests/qemu-iotests/069 | 2 +-
  tests/qemu-iotests/070 | 2 +-
  tests/qemu-iotests/071 | 2 +-
  tests/qemu-iotests/072 | 2 +-
  tests/qemu-iotests/074 | 2 +-
  tests/qemu-iotests/084 | 2 +-
  tests/qemu-iotests/085 | 2 +-
  tests/qemu-iotests/089 | 2 +-
  tests/qemu-iotests/090 | 2 +-
  tests/qemu-iotests/091 | 2 +-
  tests/qemu-iotests/094 | 2 +-
  tests/qemu-iotests/095 | 2 +-
  tests/qemu-iotests/097 | 2 +-
  tests/qemu-iotests/098 | 2 +-
  tests/qemu-iotests/099 | 2 +-
  tests/qemu-iotests/102 | 2 +-
  tests/qemu-iotests/103 | 2 +-
  tests/qemu-iotests/105 | 2 +-
  tests/qemu-iotests/106 | 2 +-
  tests/qemu-iotests/107 | 2 +-
  tests/qemu-iotests/108 | 2 +-
  tests/qemu-iotests/110 | 2 +-
  tests/qemu-iotests/111 | 2 +-
  tests/qemu-iotests/112 | 2 +-
  tests/qemu-iotests/113 | 2 +-
  tests/qemu-iotests/115 | 2 +-
  tests/qemu-iotests/117 | 2 +-
  tests/qemu-iotests/119 | 2 +-
  tests/qemu-iotests/120 | 2 +-
  tests/qemu-iotests/121 | 2 +-
  tests/qemu-iotests/123 | 2 +-
  tests/qemu-iotests/125 | 2 +-
  tests/qemu-iotests/126 | 2 +-
  tests/qemu-iotests/127 | 2 +-
  tests/qemu-iotests/135 | 2 +-
  tests/qemu-iotests/138 | 2 +-
  tests/qemu-iotests/140 | 2 +-
  tests/qemu-iotests/141 | 2 +-
  tests/qemu-iotests/143 | 2 +-
  tests/qemu-iotests/144 | 2 +-
  tests/qemu-iotests/146 | 2 +-
  tests/qemu-iotests/150 | 2 +-
  tests/qemu-iotests/153 | 2 +-
  tests/qemu-iotests/156 | 2 +-
  tests/qemu-iotests/162 | 2 +-
  tests/qemu-iotests/173 | 2 +-
  tests/qemu-iotests/176 | 2 +-
  tests/qemu-iotests/182 | 2 +-
  tests/qemu-iotests/192 | 2 +-
  tests/qemu-iotests/200 | 2 +-
  tests/qemu-iotests/216 | 2 +-
  tests/qemu-iotests/218 | 2 +-
  tests/qemu-iotests/224 | 2 +-
  tests/qemu-iotests/225 | 2 +-
  tests/qemu-iotests/228 | 2 +-
  tests/qemu-iotests/229 | 2 +-
  tests/qemu-iotests/231 | 2 +-
  tests/qemu-iotests/250 | 2 +-
  tests/qemu-iotests/251 | 2 +-
  tests/qemu-iotests/252 | 2 +-
  tests/qemu-iotests/258 | 2 +-
  tests/qemu-iotests/259 | 2 +-
  tests/qemu-iotests/261 | 2 +-
  tests/qemu-iotests/310 | 2 +-
  76 files changed, 76 insertions(+), 76 deletions(-)

diff --git a/tests/qemu-iotests/025 b/tests/qemu-iotests/025
index 80686a30d5..5771ea9200 100755
--- a/tests/qemu-iotests/025
+++ b/tests/qemu-iotests/025
@@ -20,7 +20,7 @@
  #
    # creator
-owner=stefa...@linux.vnet.ibm.com
+owner=stefa...@redhat.com

Wow, these were really old ones ... I wonder whether these "owner" lines really still make that much sense if they are neglected that much, or whether the information should maybe rather be captured in MAINTAINERS instead?

Or maybe we should just drop the whole concept of ownership in the iotests altogether, I can’t remember it ever coming up.  If a test fails, it never mattered to me who the “owner” is, I just did my best to fix it myself, usually.  If I couldn’t, I used git-blame to figure out who to ask, because tests tend to be written by multiple people anyway.

Anyway, that’d be more difficult, I suppose, because dropping ownership information would (I guess) require consent from everyone, so this is simpler for now.

Thanks for the patch, I’ve applied it to my block branch:

https://gitlab.com/hreitz/qemu/-/commits/block

Hanna


Reply via email to