Richard Henderson <richard.hender...@linaro.org> writes:
> Rename to emphasize this is the file-scope global variable.
>
> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> util/log.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/util/log.c b/util/log.c
> index 491a8f97f9..b3f79deb6c 100644
> --- a/util/log.c
> +++ b/util/log.c
> @@ -34,7 +34,7 @@ typedef struct QemuLogFile {
> FILE *fd;
> } QemuLogFile;
>
> -static char *logfilename;
> +static char *global_filename;
> static QemuMutex qemu_logfile_mutex;
> static QemuLogFile *qemu_logfile;
> int qemu_loglevel;
> @@ -151,8 +151,8 @@ static bool qemu_set_log_internal(const char *filename,
> bool changed_name,
> }
> }
>
> - g_free(logfilename);
> - logfilename = newname;
> + g_free(global_filename);
> + global_filename = newname;
> filename = newname;
I guess there is no conceivable failure mode in which we get a torn
pointer without qatomic_set?
Anyway:
Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
--
Alex Bennée
