On 5/2/22 07:39, Víctor Colombo wrote:
msr_fe0 and msr_fe1 macros hide the usage of env->msr, which is a bad
behavior. Substitute it with FIELD_EX64 calls that explicitly use
env->msr as a parameter.
Suggested-by: Richard Henderson <richard.hender...@linaro.org>
Signed-off-by: Víctor Colombo <victor.colo...@eldorado.org.br>
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
- if ((msr_fe0 == 0 && msr_fe1 == 0) ||
+ if ((!FIELD_EX64(env->msr, MSR, FE0) &&
+ !FIELD_EX64(env->msr, MSR, FE1)) ||
!FIELD_EX64(env->msr, MSR, FP)) {
This has 6 repetitions. Perhaps extract to a helper for conciseness?
r~
