* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We used to return two bools, just return a single int with the > >> following meaning: > >> > >> old return / again / new return > >> false false 0 > >> false true 1 > >> true true 2 /* We don't care about again at all */ > > > > We shouldn't use magic numbers; if you want to return it in a single > > value then it should be an enum so it is clear. > > I need to also return an error in the following patches. > I am not sure if it clearer to try to change to an enum. > Will try and see.
Well even if you used a const or #define, it would be better than having 0/1/2 all over. Dave > Later, Juan. > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
