On Tue, Aug 9, 2022 at 9:15 PM Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > > Hi > > On Fri, Aug 5, 2022 at 6:57 PM Bin Meng <bmeng...@gmail.com> wrote: >> >> From: Bin Meng <bin.m...@windriver.com> >> >> The maximum number of wait objects for win32 should be >> MAXIMUM_WAIT_OBJECTS, not MAXIMUM_WAIT_OBJECTS + 1. >> >> Signed-off-by: Bin Meng <bin.m...@windriver.com> > > > Nack, > > if wait_objects.num reaches MAXIMUM_WAIT_OBJECTS, > > then qemu_del_wait_object() will iterate up to it, and then the branch "if > (found)" will access the arrays at position i+1 == MAXIMUM_WAIT_OBJECTS. > > Note that the add functions should probably learn to avoid adding the same > HANDLE twice, otherwise del is a bit broken. >
Thanks for the review. Will fix in v2. Regards, Bin