Hi

On Wed, Aug 24, 2022 at 1:59 PM Bin Meng <bmeng...@gmail.com> wrote:

> From: Bin Meng <bin.m...@windriver.com>
>
> Replace the existing logic to get the directory for temporary files
> with g_get_tmp_dir(), which works for win32 too.
>
> Signed-off-by: Bin Meng <bin.m...@windriver.com>
>

Makes sense to me here,
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>


> ---
>
>  util/qemu-sockets.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index 83f4bd6fd2..0c41ca9e42 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -919,9 +919,8 @@ static int unix_listen_saddr(UnixSocketAddress *saddr,
>      if (saddr->path[0] || abstract) {
>          path = saddr->path;
>      } else {
> -        const char *tmpdir = getenv("TMPDIR");
> -        tmpdir = tmpdir ? tmpdir : "/tmp";
> -        path = pathbuf = g_strdup_printf("%s/qemu-socket-XXXXXX", tmpdir);
> +        path = pathbuf = g_strdup_printf("%s/qemu-socket-XXXXXX",
> +                                         g_get_tmp_dir());
>      }
>
>      pathlen = strlen(path);
> --
> 2.34.1
>
>
>

-- 
Marc-André Lureau

Reply via email to