On Mon, 5 Sept 2022 at 21:26, Richard Henderson <richard.hender...@linaro.org> wrote: > > When PAGE_WRITE_INV is set when calling tlb_set_page, > we immediately set TLB_INVALID_MASK in order to force > tlb_fill to be called on the next lookup. Here in > probe_access_internal, we have just called tlb_fill > and eliminated true misses, thus the lookup must be valid. > > This allows us to remove a warning comment from s390x. > There doesn't seem to be a reason to change the code though.
I looked at the s390 code and although it seems a bit awkward to still have the action-at-a-distance env->tlb_fill_exc, I couldn't think of an obviously neater way to do it. So assuming the s390 folks are happy with this, Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
